Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(instrumentation): remove accidental devDep on api-logs #4627

Merged
merged 2 commits into from
Apr 11, 2024
Merged

chore(instrumentation): remove accidental devDep on api-logs #4627

merged 2 commits into from
Apr 11, 2024

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Apr 10, 2024

This package accidentally got a dep and devDep on api-logs, at
different versions. The result was it being pinned at the older
version in package-lock.

@pichlermarc I am still trying to understand why the huge package-lock diff in #4621. While playing around I noticed this buglet. I'm not sure it was causing any bugs, but I think it meant that local testing of this instrumentation package (i.e. when installing with package-lock) would have been using the older api-logs.

/me gives mean eyes to npm that blithely doesn't complain when there are incompatible entries in "dependencies" and "devDependencies".

@trentm
chore(instrumentation): remove accidental devDep on api-logs
d3d5120 
This package accidentally got a dep and devDep on api-logs, at
different versions. The result was it being pinned at the older
version in package-lock.
@trentm trentm requested a review from a team April 10, 2024 23:59
@trentm
Copy link
Contributor Author

trentm commented Apr 11, 2024

Before:

% npm ls @opentelemetry/api-logs
opentelemetry@0.1.0 /Users/trentm/src/opentelemetry-js
├─┬ @opentelemetry/api-events@0.50.0 -> ./experimental/packages/api-events
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├── @opentelemetry/api-logs@0.50.0 -> ./experimental/packages/api-logs
├─┬ @opentelemetry/exporter-logs-otlp-grpc@0.50.0 -> ./experimental/packages/exporter-logs-otlp-grpc
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├─┬ @opentelemetry/exporter-logs-otlp-http@0.50.0 -> ./experimental/packages/exporter-logs-otlp-http
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├─┬ @opentelemetry/exporter-logs-otlp-proto@0.50.0 -> ./experimental/packages/exporter-logs-otlp-proto
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├─┬ @opentelemetry/instrumentation@0.50.0 -> ./experimental/packages/opentelemetry-instrumentation
│ └── @opentelemetry/api-logs@0.47.0
├─┬ @opentelemetry/otlp-transformer@0.50.0 -> ./experimental/packages/otlp-transformer
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├─┬ @opentelemetry/sdk-logs@0.50.0 -> ./experimental/packages/sdk-logs
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├─┬ @opentelemetry/sdk-node@0.50.0 -> ./experimental/packages/opentelemetry-sdk-node
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
└─┬ logs-example@0.50.0 -> ./experimental/examples/logs
  └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs

After:

% npm ls @opentelemetry/api-logs
opentelemetry@0.1.0 /Users/trentm/tm/opentelemetry-js3
├─┬ @opentelemetry/api-events@0.50.0 -> ./experimental/packages/api-events
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├── @opentelemetry/api-logs@0.50.0 -> ./experimental/packages/api-logs
├─┬ @opentelemetry/exporter-logs-otlp-grpc@0.50.0 -> ./experimental/packages/exporter-logs-otlp-grpc
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├─┬ @opentelemetry/exporter-logs-otlp-http@0.50.0 -> ./experimental/packages/exporter-logs-otlp-http
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├─┬ @opentelemetry/exporter-logs-otlp-proto@0.50.0 -> ./experimental/packages/exporter-logs-otlp-proto
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├─┬ @opentelemetry/instrumentation@0.50.0 -> ./experimental/packages/opentelemetry-instrumentation
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├─┬ @opentelemetry/otlp-transformer@0.50.0 -> ./experimental/packages/otlp-transformer
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├─┬ @opentelemetry/sdk-logs@0.50.0 -> ./experimental/packages/sdk-logs
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
├─┬ @opentelemetry/sdk-node@0.50.0 -> ./experimental/packages/opentelemetry-sdk-node
│ └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs
└─┬ logs-example@0.50.0 -> ./experimental/examples/logs
  └── @opentelemetry/api-logs@0.50.0 deduped -> ./experimental/packages/api-logs

pichlermarc
pichlermarc approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for removing this 👍

@pichlermarc pichlermarc merged commit b067aed into open-telemetry:main Apr 11, 2024
17 checks passed
@trentm trentm deleted the tm-package-lock-deps-fixes branch April 11, 2024 15:24
legalimpurity pushed a commit to legalimpurity/opentelemetry-js that referenced this pull request Apr 26, 2024
@trentm @pichlermarc @legalimpurity
chore(instrumentation): remove accidental devDep on api-logs (open-te…
72133b8 
…lemetry#4627)

This package accidentally got a dep and devDep on api-logs, at
different versions. The result was it being pinned at the older
version in package-lock.

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
@trentm @pichlermarc @Zirak
chore(instrumentation): remove accidental devDep on api-logs (open-te…
4960dc9 
…lemetry#4627)

This package accidentally got a dep and devDep on api-logs, at
different versions. The result was it being pinned at the older
version in package-lock.

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trentm @Flarna @pichlermarc